Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix normalized config key for models architecture #1408

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

echarlaix
Copy link
Collaborator

Replace key of _conf with underscore to dash so that we have the same format as the TasksManager._SUPPORTED_MODEL_TYPE

_SUPPORTED_MODEL_TYPE = {
Currently there is a mix between the two which makes this model https://huggingface.co/hf-internal-testing/tiny-random-BlenderbotSmallForCausalLM/blob/main/config.json#L27 not compatible for example

@echarlaix echarlaix requested a review from fxmarty September 22, 2023 16:21
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 22, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@fxmarty fxmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed it. LGTM!

@echarlaix echarlaix merged commit 8a0c11d into main Oct 3, 2023
50 of 54 checks passed
@echarlaix echarlaix deleted the fix-normalized-config branch October 3, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants