Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Falcon BetterTransformer requires transformers>=4.34 #1431

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Falcon BetterTransformer requires transformers>=4.34 #1431

merged 2 commits into from
Oct 6, 2023

Conversation

fxmarty
Copy link
Contributor

@fxmarty fxmarty commented Oct 5, 2023

Fixes #1430

@fxmarty fxmarty mentioned this pull request Oct 5, 2023
Closed
@fxmarty fxmarty merged commit 099cd73 into huggingface:main Oct 6, 2023
44 of 52 checks passed
fxmarty added a commit that referenced this pull request Nov 3, 2023
@fxmarty
Falcon BetterTransformer requires transformers>=4.34 (#1431)
2e8308e 
* falcon BT requires transformers>=4.34

* more fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

position_ids is now required by FalconRotaryEmbedding forward method
1 participant
@fxmarty