Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update transformers imports for deepspeed and is_torch_xla_available #2012

Merged
merged 3 commits into from
Sep 7, 2024

Conversation

Rohan138
Copy link
Contributor

@Rohan138 Rohan138 commented Sep 3, 2024

What does this PR do?

Minor fixes corresponding to huggingface/transformers#25599 and huggingface/transformers#29334

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Rohan138 Rohan138 changed the title change transformers.deepspeed to transformers.integrations.deepspeed update transformers imports for deepspeed and is_torch_xla_available Sep 5, 2024
@Rohan138
Copy link
Contributor Author

Rohan138 commented Sep 5, 2024

Resolved to check transformers versions. I also added another deprecation fix for is_torch_tpu/xla_available along the same lines.

@IlyasMoutawwakil
Copy link
Member

great thanks ! can you use this method instead

def check_if_transformers_greater(target_version: Union[str, version.Version]) -> bool:

@IlyasMoutawwakil IlyasMoutawwakil merged commit 2335ec2 into huggingface:main Sep 7, 2024
42 of 48 checks passed
@Rohan138 Rohan138 deleted the change_deepspeed_path branch October 17, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants