Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate guidance for flux #2104

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Generate guidance for flux #2104

merged 1 commit into from
Nov 26, 2024

Conversation

IlyasMoutawwakil
Copy link
Member

@IlyasMoutawwakil IlyasMoutawwakil commented Nov 26, 2024 •
edited
Loading

What does this PR do?

Fixes #2103

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

@IlyasMoutawwakil IlyasMoutawwakil mentioned this pull request Nov 26, 2024
Closed
4 tasks
@IlyasMoutawwakil
Copy link
Member Author

IlyasMoutawwakil commented Nov 26, 2024 •
edited
Loading

rerunning tests with the changed tiny random flux where guidance_embeds: true https://huggingface.co/optimum-internal-testing/tiny-random-flux/commit/d64d988ce1a80f263ab911e99014e7d3679d21b9 and https://huggingface.co/optimum-internal-testing/tiny-random-flux/commit/d7dda164cf8a1fe51283c135f67c99ab2d194ddc

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

echarlaix
echarlaix approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix @IlyasMoutawwakil

optimum/utils/input_generators.py Show resolved Hide resolved
@IlyasMoutawwakil IlyasMoutawwakil merged commit a6c696c into main Nov 26, 2024
48 of 59 checks passed
@IlyasMoutawwakil IlyasMoutawwakil deleted the generate-guidance branch November 26, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echarlaix echarlaix echarlaix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flux Pipeline doesn't work
3 participants
@IlyasMoutawwakil @HuggingFaceDocBuilderDev @echarlaix