Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Errors in setfit-onnx-optimum Notebook #496

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

danielkorat
Copy link
Collaborator

@danielkorat danielkorat commented Feb 22, 2024

Hey

I found a workaround to the errors when exporting using optimum-cli:
I run ONNX exporting + optimization programmatically instead of using the CLI, and there are no issues.
I also replaced the SetFit model with a faster one, which uses a SetFitHead.

cc @tomaarsen @MosheWasserb @orenpereg

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@danielkorat
Copy link
Collaborator Author

@tomaarsen
I added the final plot

@danielkorat
Copy link
Collaborator Author

@tomaarsen Can we merge?

@tomaarsen tomaarsen merged commit 82df763 into huggingface:main Mar 11, 2024
6 of 18 checks passed
@tomaarsen
Copy link
Member

Apologies for the delay.

@danielkorat danielkorat deleted the onnx-optimum-fix branch April 25, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants