New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add self.logger = logger for e2b_executor #537

Merged

albertvillanova merged 1 commit into huggingface:main from femto:fix_e2b_logger

Feb 7, 2025

+1 −1

Contributor

femto commented Feb 7, 2025

Hello, while trying e2b_executor example,

File "/Users/femtozheng/python-project/smolagents/src/smolagents/e2b_executor.py", line 48, in __init__

self.logger.log("Initializing E2B executor, hold on...")

^^^^^^^^^^^

AttributeError: 'E2BExecutor' object has no attribute 'logger'

python-BaseException

seemed pass in logger doesn't get set to self.logger,
so I added one.


          add self.logger = logger

63fcdc7

albertvillanova approved these changes

View reviewed changes

Member

albertvillanova left a comment

Thanks! This bug was introduced in:

Simplify managed agents #484

There was no test to catch it!

albertvillanova merged commit da1d7b9 into huggingface:main

3 checks passed

This was referenced Feb 7, 2025

Test E2B Executor #540

Merged

Fix some doc examples #542

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet