TensorRT-LLM backend bump to latest version + misc fixes #2791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormation from the engine folder
mfuntowicz
force-pushed
the
trtllm/cancellation
branch
from
5476947 to
874bc28
Compare
* chore: Add doc and CI for TRTLLM * chore: Add doc and CI for TRTLLM * chore: Add doc and CI for TRTLLM * chore: Add doc and CI for TRTLLM * doc: Formatting
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Hugoch
previously approved these changes
Dec 13, 2024
| // Define some configuration variables | ||
| executor_config.setKvCacheConfig(tle::KvCacheConfig(true)); | ||
| executor_config.setEnableChunkedContext(compute_capabilities.is_at_least_ampere()); | ||
| executor_config.setSchedulerConfig(tle::SchedulerConfig(tle::CapacitySchedulerPolicy::kMAX_UTILIZATION)); |
There was a problem hiding this comment.
Probably something we would need to have as a variable somewhere (but we need to bench the impacts first).
There was a problem hiding this comment.
What about we expose it through the CLI of the launcher mb? This way it's both CLI and ENV overridable
There was a problem hiding this comment.
Yeah but let's make sure that it's an advanced setting (I don't users to be confused by all the CLI options)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps some dependencies related to TensorRT-LLM alongside rebasing Docker container against ubuntu24.04 instead of ubuntu22.04.
To support this, we need to use latest TensorRT-LLM main due to a missing import in one of the file on Nvidia side leading to gcc failure for gcc > 12 (more info here).
It also reimplement the backbone of the backend for simplicity and alow easier testing which is actively WIP as for now but will land in its own PR as it will involve some additional changes on GA side.