Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deepseekv3/R1 #2963

Closed
wants to merge 5 commits into from
Closed

Add deepseekv3/R1 #2963

wants to merge 5 commits into from

Conversation

mht-sharma
Copy link
Collaborator

@mht-sharma mht-sharma commented Jan 28, 2025

What does this PR do?

Fixes # (issue)

  • MTP not supported in this PR

Merge after: #2928

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Dockerfile_amd Outdated
@@ -279,9 +279,9 @@ RUN git clone https://github.com/danieldk/marlin-kernels.git && \

FROM kernel-builder AS moe-kernels
WORKDIR /usr/src
ENV MOE_KERNELS_BRANCH=a67b35841774b2056a73806c36661134b5054edd
ENV MOE_KERNELS_BRANCH=0c8f8ed941635025e277d6dc6f7324827855cc40
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo: Update the installation for Nvidia

@mht-sharma mht-sharma marked this pull request as ready for review January 29, 2025 11:22
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Narsil
Copy link
Collaborator

Narsil commented Jan 29, 2025

I created another branched, rebased with all the necessary modifications to work on Nvidia (we still need to patch some dependencies).

https://github.com/huggingface/text-generation-inference/tree/add_deepseekv3_2

Thanks a TON for the modeling code, the hardest part was getting a setup working correctly.

@Narsil Narsil mentioned this pull request Jan 29, 2025
5 tasks
@Narsil
Copy link
Collaborator

Narsil commented Jan 30, 2025

Superseeded by #2968

@Narsil Narsil closed this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants