misc(gha): expose action cache url and runtime as secrets #2964
Conversation
| id: aws-creds | ||
| uses: aws-actions/configure-aws-credentials@e3dd6a429d7300a6a4c196c26e071d42e0343502 | ||
| with: | ||
| role-to-assume: ${{ secrets.AWS_ROLE_GITHUB_BUILDX_CACHE }} |
There was a problem hiding this comment.
WE still had issues with those for release, isn't that why we remvoed it altogether ?
There was a problem hiding this comment.
i increased the session time, but the run tests is failing now.
There was a problem hiding this comment.
It's not about session time, it's also that the role couldn't be assumed on anything else than PRs.
Where we need to run the CI for building and pushing also on tags/main and basically any kind of branch.
There was a problem hiding this comment.
So adding this crippled the release process.
There was a problem hiding this comment.
we can allow all branches if you need ?
There was a problem hiding this comment.
it's currently filtering on theses : refs/heads/main + refs/tags/v*
|
Maybe we should split the two scopes that we are addressing here:
wdyt @Narsil, @glegendre01 ? |
Avoid leaking token and cache url