-
Notifications
You must be signed in to change notification settings - Fork 909
Bpe clones #1707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bpe clones #1707
Conversation
It looks like this touches the codepath that lead to the slowdown in #1564, I'll look into whether this is something easy to fix. |
Rebased on main to get the new clippy fixes, should fix CI run. |
Hey! did you have anuy lead regarding this? 🤗 |
I made a comment, the reported slowdown might be explainable with the increased number of allocations when going from |
This PR tightens up the allocations by a bit. It's unlikely there are any juicy gains here, but the changes also happen to lead to terser, more clear code, so this might be an uncontroversial win.