Just import torch AdamW instead #36177
Open
+7
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rocketknight1
force-pushed
the
no-more-adamw
branch
from
4da47cc to
6338b0c
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Ready for core maintainer review @ArthurZucker @Cyrilvallez |
| @@ -604,119 +604,14 @@ def scheduler_hook(param): | |||
| ) | |||
|
|
|||
|
|
|||
| class AdamW(Optimizer): | |||
| class AdamW(TorchAdamW): | |||
There was a problem hiding this comment.
as long as you are sure all paramrs are the same for init, let'sgo! 🤗
There was a problem hiding this comment.
we can also deprecate this one?
There was a problem hiding this comment.
Good point, actually - the old one was already deprecated! Maybe we should just remove it entirely, since we've been showing a deprecation warning for a long time now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transformers added an
AdamWimplementation before Torch supported it. However, Torch supports it now so there's not really much point in maintaining our own version!This PR deletes our
AdamWclass, but importstorch.optim.AdamWin the same file, to ensure that imports that depended on it still work.Fixes #35504