Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dynamic module import when there is more than one dot in class … #36198

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

ExtReMLapin
Copy link

@ExtReMLapin ExtReMLapin commented Feb 14, 2025

…name

EXAMPLE : pylate.models.Dens

What does this PR do?

Fixes an error happening when there was more than one dot in class name ex pylate.models.Dens

@Rocketknight1
Copy link
Member

This makes sense, yes, so thank you for the PR!

Can you:

  1. Run make fixup or make style to fix the code quality CI
  2. Rebase (should fix the other failing CI issues)
  3. Add a short test in test_modeling_auto.py to make sure we don't regress on this!

After that we should be ready to merge

@ExtReMLapin ExtReMLapin changed the title Fixed dynamic module import when there is more than one dit in class … Fixed dynamic module import when there is more than one dot in class … Feb 18, 2025
@ExtReMLapin
Copy link
Author

I think the last test failing is not related.
It should be good to go, thanks for pointing me to the right direction for tests and style @Rocketknight1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants