Fix the eval_use_gather_object flag usage #36214
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #36213
After the first eval, the 2nd eval is crashing, while trying to concat batches with different shapes, as if the flag
eval_use_gather_object
stopped working. In evaluation_loop, theself.gather_function
is reset, and theeval_use_gather_object
is not usedThis PR fixes that, using the same code line, which is used at accelerator creation.
@muellerzr and @SunMarc