Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated args in trainers #2036

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

qgallouedec
Copy link
Member

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I'm happy to remove these args, but since it's technically a breaking change I wonder if we need to specify the specific version we'll do this in (currently set to v1.0.0 which is too far away I guess)

Also it would be good to have a small PR description as I wasn't quite sure what the motivation of this PR was :)

@@ -389,74 +388,22 @@ class DPOTrainer(Trainer):

_tag_names = ["trl", "dpo"]

@_deprecate_arguments(
version="1.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, is the reason to remove these deprecated args due to the fact we've had this warning for several releases?

I wonder if it's better to pin the version to 2-3 future versions to give people a concrete warning?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context, these arguments have been deprecated in #1554, in v0.9.3.

Sounds good, let's wait a bit.

@qgallouedec qgallouedec marked this pull request as draft September 17, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants