-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated args in trainers #2036
base: main
Are you sure you want to change the base?
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I'm happy to remove these args, but since it's technically a breaking change I wonder if we need to specify the specific version we'll do this in (currently set to v1.0.0
which is too far away I guess)
Also it would be good to have a small PR description as I wasn't quite sure what the motivation of this PR was :)
@@ -389,74 +388,22 @@ class DPOTrainer(Trainer): | |||
|
|||
_tag_names = ["trl", "dpo"] | |||
|
|||
@_deprecate_arguments( | |||
version="1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, is the reason to remove these deprecated args due to the fact we've had this warning for several releases?
I wonder if it's better to pin the version
to 2-3 future versions to give people a concrete warning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.