Skip to content

Support FSDP2 in GRPOTrainer #3670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

thepowerfuldeez
Copy link
Contributor

Following the idea from #3317 (comment) I updated _sync_fsdp_params_to_vllm with FSDP2 summon code

@thepowerfuldeez
Copy link
Contributor Author

I'm not strong at FSDP2 so this impl might be incomplete

But without this addition previously params were never synced from vllm to trl code, making the model never train with FSDP2

@kashif
Copy link
Collaborator

kashif commented Jul 28, 2025

thanks @thepowerfuldeez If its ok with you, we are going to use the #3687 instead of this PR

@thepowerfuldeez
Copy link
Contributor Author

@kashif no worries!

@kashif
Copy link
Collaborator

kashif commented Jul 28, 2025

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants