-
Notifications
You must be signed in to change notification settings - Fork 2.2k
🧹 Remove max_batch_tokens
, num_blocks
and block_size
from generation kwargs
#4065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
As a reminder, while |
thanks for the feedback @remi-or!
will do! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if the test of the change in block_size
does not have a negative impact. Otherwise, we should keep the original 128 value.
Tried with 0.5B and 1.7B, no difference between block_size=32 and 128👍 |
These parameters are now automatically computed, see huggingface/transformers#40426