Fix IRC RC feed #375
Fix IRC RC feed #375
Conversation
This works around an incompatibility between libirc and the new IRC RC server implementation.
|
Hello, @cdhowie thanks for report, I have decided to instead fix this bug in the underlying library: grumpy-irc/libirc@92b8407 so that we don't need to fix this with a workaround :) |
|
@benapetr Funny, that commit is identical to one I made on libirc to fix the issue but didn't realize that Huggle and libirc shared authors. I figured a workaround would be faster than trying to get a fix into a "third party" library quickly. Guess it's not really a third party library. :) |
|
@cdhowie technically from huggle's perspective it is 3rd, from my personal, not so much. But still probably it's cleaner to at least submit a PR for a fix in the upstream while making a workaround. Anyway how big problem is this issue, I don't really use Huggle myself that much, but was there any recent change in the IRC server wikimedia uses? Did the IRC feed stop working entirely? If yes, I think this would justify a release. |
|
@benapetr There was indeed a change to the IRC RC server implementation. Yes, the IRC feed is completely broken in Huggle without this patch. |
Respond to MYINFO with four distinct parameters, not one with all parameters concatenated. This was breaking Huggle, per phab:T378667, also see huggle/huggle3-qt-lx#375. It was worked around since, but this was an ircstream bug that had to be fixed anyway.
|
As you all suspected, this was indeed a bug in the server. I just fixed it and released v1.0.1. Hopefully the WMF folks will update irc.wikimedia.org to it soon! I'd appreciate testing Huggle & GrumpyIrc against v1.0.1 even before that. BTW, if we could find a way to include Huggle in ircstream's test suite that'd be amazing too! Suggestions and/or PRs more than welcome 😄 |
This works around an incompatibility between libirc and the new IRC RC server implementation. The new RC server only sends one parameter with the MYINFO command; libirc expects 4, or it won't autojoin. This patch has Huggle take care of sending the join after seeing MYINFO, regardless of the number of arguments.