Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate: Make missing <releases> more obvious #376

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Jul 18, 2020

Previously, when <release> was not contained in <releases>, the following confusing error message was printed:

• tag-missing           : <release> required

Now, the validation will print

• tag-missing           : <releases> required

when is missing altogether and

• tag-missing           : <release> required in <releases>

when the <releases> tag does not contain any <release>.

Fixes: #375

Previously, when <release> was not contained in <releases>, the following confusing
error message was printed:

    • tag-missing           : <release> required

Now, the validation will print

    • tag-missing           : <releases> required

when <releases> is missing altogether and

    • tag-missing           : <release> required in <releases>

when the <releases> tag does not contain any <release>.
@jtojnar
Copy link
Contributor Author

jtojnar commented Jul 18, 2020

This slightly improves that particular confusing warning but it is still far from ideal since it is too weak model at the moment. Ideally, we would use something like XSD schema for doing the boring validity check and only write code for checking things that cannot be expressed in schemas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing “release required” error
1 participant