Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more type hints #181

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Add some more type hints #181

merged 1 commit into from
Nov 12, 2023

Conversation

hugovk
Copy link
Owner

@hugovk hugovk commented Nov 12, 2023

Not yet ready to enable mypy in pre-commit.

@hugovk hugovk added changelog: skip Exclude PR from release draft changelog: Added For new features and removed changelog: skip Exclude PR from release draft labels Nov 12, 2023
Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Merging #181 (180ce25) into main (dc7e75b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #181   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files           7        7           
  Lines         390      391    +1     
=======================================
+ Hits          386      387    +1     
  Misses          4        4           
Flag Coverage Δ
macos-latest 98.97% <100.00%> (+<0.01%) ⬆️
ubuntu-latest 98.97% <100.00%> (+<0.01%) ⬆️
windows-latest 98.97% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/norwegianblue/__init__.py 98.68% <ø> (ø)
src/norwegianblue/_cache.py 94.11% <100.00%> (ø)
src/norwegianblue/_data.py 100.00% <100.00%> (ø)
tests/test_norwegianblue.py 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@hugovk hugovk merged commit af73b04 into main Nov 12, 2023
58 checks passed
@hugovk hugovk deleted the mypy branch November 12, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Added For new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant