Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --show-title flag #196

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Add --show-title flag #196

merged 3 commits into from
Feb 14, 2024

Conversation

elliotwutingfeng
Copy link
Contributor

Closes #192

Default behavior remains unchanged; Single product -> No title, Multiple products -> Show title for each product

If --show-title is yes, title is always shown. When no, title is never shown.

Copy link

codecov bot commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fff64dd) 98.99% compared to head (2663053) 98.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #196   +/-   ##
=======================================
  Coverage   98.99%   98.99%           
=======================================
  Files           7        7           
  Lines         399      399           
=======================================
  Hits          395      395           
  Misses          4        4           
Flag Coverage Δ
macos-latest 98.99% <ø> (ø)
ubuntu-latest 98.99% <ø> (?)
windows-latest 98.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugovk hugovk added the changelog: Added For new features label Feb 14, 2024
@hugovk hugovk merged commit 06842b6 into hugovk:main Feb 14, 2024
31 of 32 checks passed
@hugovk
Copy link
Owner

hugovk commented Feb 14, 2024

Thank you!

@hugovk hugovk changed the title Add --show-title flag Add --show-title flag Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Added For new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Expose show_title option in CLI
2 participants