Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use args.show_title after accepting suggestion #198

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

elliotwutingfeng
Copy link
Contributor

Bugfix for args.show_title not being used after accepting a Did you mean [Y/n] suggestion.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.99%. Comparing base (ba7789f) to head (a34f5a7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #198   +/-   ##
=======================================
  Coverage   98.99%   98.99%           
=======================================
  Files           7        7           
  Lines         399      399           
=======================================
  Hits          395      395           
  Misses          4        4           
Flag Coverage Δ
macos-latest 98.99% <ø> (ø)
ubuntu-latest 98.99% <ø> (ø)
windows-latest 98.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugovk hugovk added the changelog: Fixed For any bug fixes label Feb 23, 2024
src/norwegianblue/cli.py Outdated Show resolved Hide resolved
@hugovk hugovk changed the title Use args.show_title after accepting suggestion. Use args.show_title after accepting suggestion Feb 23, 2024
@hugovk hugovk merged commit cd24970 into hugovk:main Feb 23, 2024
31 checks passed
@hugovk
Copy link
Owner

hugovk commented Feb 23, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Fixed For any bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants