Added an optional performCustomAnimations method in CKClusterManagerD… #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elegate to give option of implementing animations in a custom way.
…llapse/expand animations.
|
Nice work here @aramsargsyan and sorry for the late reply. Instead of adding the type as a - (void)clusterManager:(CKClusterManager *)clusterManager performAnimations:(void (^)(void))animations type:(CKClusterAnimationType)type completion:(void (^ __nullable)(BOOL finished))completion;In order to be merged, you will also need to update MapKit, GoogleMaps and YandexMapKit extensions. |
maxep
reviewed
Jul 17, 2020
| @@ -65,7 +65,7 @@ MK_EXTERN NSComparisonResult MKMapSizeCompare(MKMapSize size1, MKMapSize size2); | |||
| /** | |||
| Cluster coordinate. | |||
| */ | |||
| @property (nonatomic, readonly) CLLocationCoordinate2D coordinate; | |||
| @property (nonatomic) CLLocationCoordinate2D coordinate; | |||
There was a problem hiding this comment.
I don't think this change is required as CKCluster implements the MKAnnotation method setCoordinate:.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an option for users of the library to implement animations in a custom way. Giving out the [CKClusterAnimation] array gives the possibility to implement the animations in any desirable way. I added another method in the delegate instead of changing the current one for the existing users of the library not to have to change much code.