Add SWR threshold capability #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will work automatically with Batcache, as it only instructs CloudFront to change its behaviour, rather than everything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will work automatically with Batcache, as it only instructs CloudFront to change its behaviour, rather than everything.
stale-while-revalidatetime is basically added tomax-age, so ifmax-ageis 600 and swr is 60, the item will last in CloudFront for 660 seconds.I picked 30/60s here as thresholds; it's diminishing returns past that. It shouldn't take more than 30s to regenerate a request anyway, so for frequently accessed data, it should basically always be served from the cache now.