add default callback support #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy4groovy
force-pushed
the
default-callback
branch
5 times, most recently
from
5ab1f9f to
962cdea
Compare
crazy4groovy
commented
Nov 8, 2021
| if (typeof defaultValue === "function") { | ||
| // resolve the callback defaultValue | ||
| defaultValue = defaultValue(index); | ||
| return target[property] = defaultValue; |
There was a problem hiding this comment.
We could also only assign to target[property] if the resolved defaultValue is an object. There are this.length implications either way. Thoughts?
crazy4groovy
force-pushed
the
default-callback
branch
2 times, most recently
from
9e00017 to
befe222
Compare
crazy4groovy
force-pushed
the
default-callback
branch
from
befe222 to
659ec36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@humanwhocodes:
tests passing.
feedback?