Accommodate upstream Windows vulkan_sdk.exe structure changes #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
want to test this a bit more before merging into main and cutting v1.3 release. to utilize the proposed fix sooner than v1.3, here the commit hash style -name: Install Vulkan SDK
uses: humbletim/install-vulkan-sdk@033219e2d69dd4d3e873e217eb385fdd4b4438f4
with:
version: 1.4.321.0
cache: true |
|
CC:
|
|
Nice, I've updated my GitHub Actions to use the specific commit to test it, and it fixed the problems I was having (issue #17). Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue with the Vulkan SDK installation on Windows, where recent changes to the installer's structure broke the existing
7zextraction method and causedFindVulkanto fail in CMake.Problem
Sometime in the recent past the internal layout of the official Vulkan SDK installers for Windows was modified. As a result, simply extracting the archive with
7zno longer provides the necessary SDK headers (Include/directory), making the SDK unusable for compilation.Solution
This PR implements a more robust, "fall-forward" installation strategy for Windows:
vulkan_sdk.exearchive to see if theInclude/directory is present at the top level.7zextraction method.The command used for the new unattended installation is:
./vulkan_sdk.exe --root "$VULKAN_SDK" --accept-licenses --default-answer --confirm-command installCommentary
While invoking the installer directly is a pragmatic solution, the original preference for
7zwas intentional. Surgically extracting contents is a security-conscious approach that minimizes the potential for side-effects (e.g., avoids creating system menu shortcuts, modifying the registry, or attempting to install other dependencies). It also aligns with the core principle of this action: providing a self-contained SDK environment without system-wide modifications.The need for this change highlights a recurring challenge for open-source maintainers who depend on pre-built artifacts. Seemingly arbitrary changes to tooling and packaging can have a cascading effect, creating downstream work for the volunteer community. A more stable and predictable release process from SDK providers would be beneficial for the entire ecosystem..
See also:
CC: