Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the intention of a search path setting and avoid using string in check if file exists #109

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Fix the intention of a search path setting and avoid using string in check if file exists #109

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0017474
fix uploadmodel search path intention
mredig Sep 23, 2024
13a0897
avoid using string path in checking for file existing
mredig Sep 23, 2024
283b08a
revert indentation
mredig Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions upload/Sources/App/Models/UploadModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ extension UploadModel {
/// - Returns: the target directory for uploads
func destinationURL(searchPath: FileManager.SearchPathDirectory = .documentDirectory, allowsOverwrite: Bool = false) throws -> URL {
let fileURL = try FileManager.default.url(
for: .documentDirectory,
for: searchPath,
in: .userDomainMask,
appropriateFor: nil,
create: true
).appendingPathComponent(self.filename)

guard allowsOverwrite == false else { return fileURL }
guard FileManager.default.fileExists(atPath: fileURL.path) == false else {
guard (try? fileURL.checkResourceIsReachable()) == false else {
throw HTTPError(.conflict)
}
return fileURL
Expand Down