One Time Password example #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joannis
reviewed
Sep 28, 2024
Comment on lines
36
to
37
| let computedTOTP = TOTP(secret: otpVerificationSession.secret).compute(date: .now - 15.0) | ||
| let computedTOTP2 = TOTP(secret: otpVerificationSession.secret).compute(date: .now + 15.0) |
There was a problem hiding this comment.
Very much a nit, but theoretically the distance between .now the first and second time can theoretically change enough to create an issue. I don't think we care for an example, but wanted to give you that info.
Joannis
reviewed
Sep 28, 2024
|
Updated to include latest from auth. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard username, password authentication which can be extended to include a TOTP token input
This uses the session PR in hummingbird-auth