Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webauthn example for 2.x.x #54

Merged
merged 6 commits into from
Jan 24, 2024
Merged

Update webauthn example for 2.x.x #54

merged 6 commits into from
Jan 24, 2024

Conversation

adam-fowler
Copy link
Member

@adam-fowler adam-fowler commented Jan 23, 2024

Also uses HummingbirdRouter

@adam-fowler adam-fowler changed the base branch from main to 2.x.x January 23, 2024 15:13
@adam-fowler adam-fowler changed the title Update webauthn example Update webauthn example for 2.x.x Jan 23, 2024
Copy link
Member

@Joannis Joannis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

webauthn/README.md Outdated Show resolved Hide resolved
session: session,
expiresIn: .minutes(10)
expiresIn: .seconds(600)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duration doesn't have a static function minutes

Co-authored-by: Joannis Orlandos <[email protected]>
@adam-fowler adam-fowler merged commit 97aaf0b into 2.x.x Jan 24, 2024
1 check passed
@adam-fowler adam-fowler deleted the 2.x.x-webauthn branch January 24, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants