Get HummingbirdFluent working with HB 2.0 #11
Conversation
Wrap migrations in a MainActorBox Wrap Databases in a UnsafeTransfer
adam-fowler
force-pushed
the
2.x.x-working
branch
from
39da381
to
1489205
Compare
| public let history: History | ||
| /// List of migrations. Only accessible from the main actor | ||
| @MainActor | ||
| public var migrations: Migrations { self._migrations.value } |
There was a problem hiding this comment.
I'm currently using @MainActor here. @Joannis what are your thoughts on setting up a Hummingbird global actor in Hummingbird and using that instead.
There was a problem hiding this comment.
Do you foresee other places where you'd want/need this? What's the "domain" of the actor? What type of information do you scope it to?
There was a problem hiding this comment.
At this point I time probably not so we can keep as @MainActor. The migration stuff should only be setup during initialisation.
| } catch { | ||
| return request.eventLoop.makeFailedFuture(error) | ||
| print("\(error)") |
| } catch { | ||
| return request.eventLoop.makeFailedFuture(error) | ||
| print("\(error)") |
It's not like I've used it a great deal. I'm not really a fan. I basically provided this as I know a lot of people rely on it. |
Remove HBApplication extensions
HBFlluent is now a Service.
Make HBFluent Sendable by
Update HBFluentPersistDriver