Use a transaction for migrations #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joannis
approved these changes
Mar 10, 2025
|
Test failing to compile |
thoven87
reviewed
Mar 10, 2025
| @@ -401,21 +401,21 @@ struct PostgresMigrationRepository: Sendable { | |||
|
|
|||
| let client: PostgresClient | |||
| #if compiler(>=6.0) | |||
There was a problem hiding this comment.
I think we can get rid of these version check since the transaction implementation already has checks for isolating stuff?
There was a problem hiding this comment.
That has to be in each async function call
There was a problem hiding this comment.
That has to be in each async function call
oh, I see!
thoven87
reviewed
Mar 10, 2025
| try await process(.init(connection: connection, logger: logger)) | ||
| } | ||
| } | ||
| #else | ||
| func withContext<Value: Sendable>( |
There was a problem hiding this comment.
Do we need to still wrap this code in a closure? see https://github.com/vapor/postgres-nio/pull/538/files
There was a problem hiding this comment.
It hides the implementation details a little. I could remove it but not sure it is necessary
Joannis
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.