Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move job serialisation to driver #22

Merged
merged 4 commits into from
Feb 22, 2025
Merged

Move job serialisation to driver #22

merged 4 commits into from
Feb 22, 2025

Conversation

adam-fowler
Copy link
Member

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 94.73684% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.59%. Comparing base (d59ff63) to head (e45bf31).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/JobsRedis/RedisJobQueue.swift 94.73% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   88.67%   89.59%   +0.91%     
==========================================
  Files           3        3              
  Lines         212      221       +9     
==========================================
+ Hits          188      198      +10     
+ Misses         24       23       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@thoven87 thoven87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adam-fowler adam-fowler changed the title Move job serialisation moved to driver Move job serialisation to driver Feb 21, 2025
@adam-fowler adam-fowler merged commit b646b55 into main Feb 22, 2025
7 of 9 checks passed
@adam-fowler adam-fowler deleted the job-driver-parameters branch February 22, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants