Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bin price same as buy price result error #52

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gfanzh
Copy link

@gfanzh gfanzh commented Feb 7, 2016

No description provided.

@gfanzh
Copy link
Author

gfanzh commented Feb 7, 2016

Also updated core/watch.py to not rely on lowest bin since it's pretty flaky.
This might be controversial. Let me know if you don't like it.

@hunterjm
Copy link
Owner

hunterjm commented Feb 8, 2016

I like the fix for same bin/buy pricing, but I'm not sure about the auto-update using the third lowest price. My reasoning being that, in my opinion, it is always better to set our threshold for buying players too low than it would be to set it too high. For example, if you are working with players in the 1-2k range, the difference of 100 coins could be the difference between whether or not it sells. I don't want to buy 10 players for 1800 if there are two BINs at 1700.

That being said, I know that the PC market has far less players, so the numbers can be more flaky than console. Maybe we add another setting that lets the user choose which to use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants