Fix TF and improve configuration. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafal-gorecki
commented
Sep 2, 2024
rafal-gorecki
commented
- Fix tf frame name (add missing /)
- Additionals params: for initioal position
- Update README
|
Before merge generate and update image tag in demo. |
rafal-gorecki
commented
Oct 29, 2024
demo/compose.yaml
Outdated
| @@ -17,6 +17,4 @@ services: | |||
| - ./velodyne.launch.py:/velodyne.launch.py | |||
There was a problem hiding this comment.
Now unnecessary
Suggested change
| - ./velodyne.launch.py:/velodyne.launch.py |
Can also delete panther_ prefix
rafal-gorecki
commented
Nov 25, 2024
rafal-gorecki
commented
Nov 25, 2024
| @@ -8,7 +8,7 @@ x-common-config: &common-config | |||
|
|
|||
| services: | |||
| velodyne: | |||
| image: husarion/velodyne:humble-2.4.0-20240723 | |||
| image: husarion/velodyne:humble-ros2-fix-tf # TODO: change after bump | |||
There was a problem hiding this comment.
Suggested change
| image: husarion/velodyne:humble-ros2-fix-tf # TODO: change after bump | |
| image: husarion/velodyne:humble-2.4.0-20241125 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.