fix duplicate bind event, fixed #155

hustcc · Mar 2, 2018 · 44c1e27 · 44c1e27
1 parent caa31b4
commit 44c1e27
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 4 deletions.
diff --git a/demo/dist/bundle.js b/demo/dist/bundle.js
diff --git a/demo/src/charts/Events.jsx b/demo/src/charts/Events.jsx
@@ -2,6 +2,12 @@ import React, { PureComponent } from 'react';
 import ReactEcharts from '../../../src/index';
 
 export default class Events extends PureComponent {
+  constructor(props) {
+    super(props);
+    this.state = {
+      cnt: 0,
+    };
+  }
   getOption = () => ({
     title : {
       text: '某站点用户访问来源',
@@ -44,6 +50,9 @@ export default class Events extends PureComponent {
   onChartClick = (param, echarts) => {
     console.log(param, echarts);
     alert('chart click');
+    this.setState({
+      cnt: this.state.cnt + 1,
+    })
   };
 
   onChartLegendselectchanged = (param, echart) => {
@@ -73,7 +82,7 @@ export default class Events extends PureComponent {
     return (
       <div className='examples'>
         <div className='parent'>
-          <label> Chart With event <strong> onEvents </strong>: (Click the chart, and watch the console)</label>
+          <label> Chart With event <strong> onEvents </strong>（{this.state.cnt}）: (Click the chart, and watch the console)</label>
           <ReactEcharts
             option={this.getOption()}
             style={{height: 300}}

diff --git a/lib/core.js b/lib/core.js
@@ -51,6 +51,7 @@ var EchartsReactCore = function (_Component) {
         try {
           _elementResizeEvent2['default'].unbind(_this.echartsElement);
         } catch (_) {}
+        // dispose echarts instance
         _this.echartsLib.dispose(_this.echartsElement);
       }
     };
@@ -130,7 +131,6 @@ var EchartsReactCore = function (_Component) {
     key: 'componentDidUpdate',
     value: function componentDidUpdate(prevProps) {
       var echartObj = this.renderEchartDom();
-      this.bindEvents(echartObj, this.props.onEvents || {});
 
       // 以下属性修改的时候，需要 dispose 之后再新建
       // 1. 切换 theme 的时候

diff --git a/src/core.jsx b/src/core.jsx
@@ -19,7 +19,6 @@ export default class EchartsReactCore extends Component {
   // update
   componentDidUpdate(prevProps) {
     const echartObj = this.renderEchartDom();
-    this.bindEvents(echartObj, this.props.onEvents || {});
 
     // 以下属性修改的时候，需要 dispose 之后再新建
     // 1. 切换 theme 的时候
@@ -60,6 +59,7 @@ export default class EchartsReactCore extends Component {
       try {
         elementResizeEvent.unbind(this.echartsElement);
       } catch (_) {}
+      // dispose echarts instance
       this.echartsLib.dispose(this.echartsElement);
     }
   };