fix: various crashing exceptions

Screenbox.Core/Helpers/LastPositionTracker.cs

@@ -75,7 +75,7 @@ public async Task SaveToDiskAsync(IFilesService filesService)
         {
             try
             {
-                await filesService.SaveToDiskAsync(ApplicationData.Current.TemporaryFolder, SaveFileName, _lastPositions);
+                await filesService.SaveToDiskAsync(ApplicationData.Current.TemporaryFolder, SaveFileName, _lastPositions.ToList());
             }
             catch (FileLoadException)
             {

Screenbox.Core/ViewModels/AlbumDetailsPageViewModel.cs

@@ -18,13 +18,13 @@ public sealed partial class AlbumDetailsPageViewModel : ObservableRecipient
         [NotifyPropertyChangedFor(nameof(Year))]
         [NotifyPropertyChangedFor(nameof(SongsCount))]
         [NotifyPropertyChangedFor(nameof(TotalDuration))]
-        private AlbumViewModel _source = null!;
+        private AlbumViewModel? _source;
 
-        public uint? Year => Source.Year;
+        public uint? Year => Source?.Year;
 
-        public int SongsCount => Source.RelatedSongs.Count;
+        public int SongsCount => Source?.RelatedSongs.Count ?? 0;
 
-        public TimeSpan TotalDuration => GetTotalDuration(Source.RelatedSongs);
+        public TimeSpan TotalDuration => Source != null ? GetTotalDuration(Source.RelatedSongs) : TimeSpan.Zero;
 
         public ObservableCollection<MediaViewModel> SortedItems { get; }
 
@@ -45,8 +45,15 @@ public void OnNavigatedTo(object? parameter)
             };
         }
 
-        async partial void OnSourceChanged(AlbumViewModel value)
+        async partial void OnSourceChanged(AlbumViewModel? value)
         {
+            if (value == null)
+            {
+                SortedItems.Clear();
+                _itemList = null;
+                return;
+            }
+
             var sorted = value.RelatedSongs.OrderBy(m =>
                     m.MediaInfo.MusicProperties.TrackNumber != 0    // Track number should start with 1
                         ? m.MediaInfo.MusicProperties.TrackNumber
@@ -75,7 +82,7 @@ private void Play(MediaViewModel item)
         [RelayCommand]
         private void ShuffleAndPlay()
         {
-            if (Source.RelatedSongs.Count == 0) return;
+            if (Source == null || Source.RelatedSongs.Count == 0) return;
             Random rnd = new();
             List<MediaViewModel> shuffledList = Source.RelatedSongs.OrderBy(_ => rnd.Next()).ToList();
             Messenger.Send(new ClearPlaylistMessage());

Screenbox.Core/ViewModels/ArtistDetailsPageViewModel.cs

@@ -17,23 +17,22 @@ public sealed partial class ArtistDetailsPageViewModel : ObservableRecipient
         [ObservableProperty]
         [NotifyPropertyChangedFor(nameof(TotalDuration))]
         [NotifyPropertyChangedFor(nameof(SongsCount))]
-        private ArtistViewModel _source;
+        private ArtistViewModel? _source;
 
         [ObservableProperty]
         [NotifyPropertyChangedFor(nameof(AlbumsCount))]
         private List<IGrouping<AlbumViewModel?, MediaViewModel>> _albums;
 
-        public TimeSpan TotalDuration => GetTotalDuration(Source.RelatedSongs);
+        public TimeSpan TotalDuration => Source != null ? GetTotalDuration(Source.RelatedSongs) : TimeSpan.Zero;
 
         public int AlbumsCount => Albums.Count;
 
-        public int SongsCount => Source.RelatedSongs.Count;
+        public int SongsCount => Source?.RelatedSongs.Count ?? 0;
 
         private List<MediaViewModel>? _itemList;
 
         public ArtistDetailsPageViewModel()
         {
-            _source = new ArtistViewModel();
             _albums = new List<IGrouping<AlbumViewModel?, MediaViewModel>>();
         }
 
@@ -47,8 +46,14 @@ public void OnNavigatedTo(object? parameter)
             };
         }
 
-        async partial void OnSourceChanged(ArtistViewModel value)
+        async partial void OnSourceChanged(ArtistViewModel? value)
         {
+            if (value == null)
+            {
+                Albums = new List<IGrouping<AlbumViewModel?, MediaViewModel>>();
+                return;
+            }
+
             Albums = value.RelatedSongs
                 .OrderBy(m => m.MediaInfo.MusicProperties.TrackNumber)
                 .ThenBy(m => m.Name, StringComparer.CurrentCulture)
@@ -71,7 +76,7 @@ private void Play(MediaViewModel? media)
         [RelayCommand]
         private void ShuffleAndPlay()
         {
-            if (Source.RelatedSongs.Count == 0) return;
+            if (Source == null || Source.RelatedSongs.Count == 0) return;
             Random rnd = new();
             List<MediaViewModel> shuffledList = Source.RelatedSongs.OrderBy(_ => rnd.Next()).ToList();
             Messenger.Send(new ClearPlaylistMessage());

Screenbox.Core/ViewModels/ArtistViewModel.cs

@@ -22,18 +22,13 @@ public sealed partial class ArtistViewModel : ObservableRecipient
 
         [ObservableProperty] private bool _isPlaying;
 
-        public ArtistViewModel()
+        public ArtistViewModel(string artist)
         {
-            Name = string.Empty;
+            Name = artist;
             RelatedSongs = new ObservableCollection<MediaViewModel>();
             RelatedSongs.CollectionChanged += RelatedSongsOnCollectionChanged;
         }
 
-        public ArtistViewModel(string artist) : this()
-        {
-            Name = artist;
-        }
-
         public override string ToString()
         {
             return Name;

Screenbox.Core/ViewModels/HomePageViewModel.cs

@@ -260,6 +260,11 @@ private async Task OpenFolderAsync()
             {
                 return null;
             }
+            catch (Exception e)
+            {
+                LogService.Log(e);
+                return null;
+            }
         }
     }
 }

Screenbox.Core/ViewModels/LivelyWallpaperPlayerViewModel.cs

@@ -103,7 +103,7 @@ public async Task LoadAsync()
 
     public async Task NavigatePage(WebView2 webView)
     {
-        if (Source is null)
+        if (Source is null || webView.CoreWebView2 == null)
             return;
 
         if (string.IsNullOrEmpty(Source.Path) || string.IsNullOrEmpty(Source.Model.FileName))
@@ -189,7 +189,8 @@ public async Task UpdatePauseState(WebView2 webView, bool isPaused)
     // Ref: https://github.com/rocksdanister/lively/wiki/Web-Guide-V-:-System-Data#--system-nowplaying
     public async Task UpdateCurrentTrack(WebView2 webView)
     {
-        if (Source is null || Media == null || webView.CoreWebView2.IsSuspended || !Source.IsMusic)
+        if (Source is null || Media == null || webView.CoreWebView2 == null ||
+            webView.CoreWebView2.IsSuspended || !Source.IsMusic)
             return;
 
         var model = new LivelyMusicModel

Screenbox.Core/ViewModels/MediaViewModel.cs

@@ -225,17 +225,7 @@ public async Task LoadDetailsAsync(IFilesService filesService)
                 case StorageFile file:
                     MediaInfo = await filesService.GetMediaInfoAsync(file);
                     break;
-                case Uri { IsFile: true, IsLoopback: true, IsAbsoluteUri: true } uri:
-                    StorageFile uriFile;
-                    try
-                    {
-                        uriFile = await StorageFile.GetFileFromPathAsync(uri.OriginalString);
-                    }
-                    catch (IOException)
-                    {
-                        return;
-                    }
-
+                case Uri uri when await TryGetStorageFileFromUri(uri) is { } uriFile:
                     UpdateSource(uriFile);
                     MediaInfo = await filesService.GetMediaInfoAsync(uriFile);
                     break;
@@ -276,17 +266,9 @@ public async Task LoadDetailsAsync(IFilesService filesService)
         public async Task LoadThumbnailAsync()
         {
             if (Thumbnail != null) return;
-            if (Source is Uri { IsFile: true, IsLoopback: true, IsAbsoluteUri: true } uri)
+            if (Source is Uri uri && await TryGetStorageFileFromUri(uri) is { } storageFile)
             {
-                try
-                {
-                    StorageFile uriFile = await StorageFile.GetFileFromPathAsync(uri.OriginalString);
-                    UpdateSource(uriFile);
-                }
-                catch (IOException)
-                {
-                    return;
-                }
+                UpdateSource(storageFile);
             }
 
             if (Source is StorageFile file)
@@ -456,5 +438,22 @@ private void UpdateCaptions()
                 }
             }
         }
+
+        private static async Task<StorageFile?> TryGetStorageFileFromUri(Uri uri)
+        {
+            if (uri is { IsFile: true, IsLoopback: true, IsAbsoluteUri: true })
+            {
+                try
+                {
+                    return await StorageFile.GetFileFromPathAsync(uri.OriginalString);
+                }
+                catch (Exception)
+                {
+                    return null;
+                }
+            }
+
+            return null;
+        }
     }
 }

Screenbox/Pages/AlbumDetailsPage.xaml

@@ -113,12 +113,12 @@
                     SizeChanged="AlbumArt_OnSizeChanged"
                     Translation="0,0,16">
                     <Grid.Background>
-                        <ImageBrush ImageSource="{x:Bind ViewModel.Source.AlbumArt, Mode=OneWay}" Stretch="UniformToFill" />
+                        <ImageBrush ImageSource="{x:Bind ViewModel.Source.AlbumArt, Mode=OneWay, FallbackValue={x:Null}}" Stretch="UniformToFill" />
                     </Grid.Background>
                     <Border
                         Background="{ThemeResource SolidBackgroundFillColorSecondaryBrush}"
                         CornerRadius="{x:Bind CoverArt.CornerRadius, Mode=OneWay}"
-                        Visibility="{x:Bind ViewModel.Source.AlbumArt, Mode=OneWay, Converter={StaticResource EmptyObjectToVisibilityConverter}, ConverterParameter=true}">
+                        Visibility="{x:Bind ViewModel.Source.AlbumArt, Mode=OneWay, Converter={StaticResource EmptyObjectToVisibilityConverter}, ConverterParameter=true, FallbackValue=Visible}">
                         <FontIcon
                             x:Name="CoverArtIcon"
                             FontSize="64"
@@ -134,7 +134,7 @@
                     <TextBlock
                         x:Name="TitleText"
                         Style="{StaticResource TitleMediumTextBlockStyle}"
-                        Text="{x:Bind ViewModel.Source.Name}"
+                        Text="{x:Bind ViewModel.Source.Name, FallbackValue={x:Null}}"
                         TextWrapping="NoWrap">
                         <interactivity:Interaction.Behaviors>
                             <interactions:OverflowTextToolTipBehavior />
@@ -146,7 +146,7 @@
                         Margin="0,8,0,0"
                         FontWeight="Normal"
                         Style="{StaticResource SubtitleTextBlockStyle}"
-                        Text="{x:Bind ViewModel.Source.ArtistName}"
+                        Text="{x:Bind ViewModel.Source.ArtistName, FallbackValue={x:Null}}"
                         TextWrapping="NoWrap">
                         <interactivity:Interaction.Behaviors>
                             <interactions:OverflowTextToolTipBehavior />

Screenbox/Pages/AlbumDetailsPage.xaml.cs

@@ -86,7 +86,7 @@ private async void AlbumDetailsPage_OnLoaded(object sender, RoutedEventArgs e)
 
             CreateHeaderAnimation(_props, scrollingProperties.Translation.Y);
 
-            if (ViewModel.Source.RelatedSongs.Count == 0) return;
+            if (ViewModel.Source == null || ViewModel.Source.RelatedSongs.Count == 0) return;
             MediaViewModel firstSong = ViewModel.Source.RelatedSongs[0];
             if (firstSong.Thumbnail != null)
             {

Screenbox/Pages/ArtistDetailsPage.xaml

@@ -215,7 +215,7 @@
                     <TextBlock
                         x:Name="TitleText"
                         Style="{StaticResource TitleMediumTextBlockStyle}"
-                        Text="{x:Bind ViewModel.Source.Name}"
+                        Text="{x:Bind ViewModel.Source.Name, FallbackValue={x:Null}}"
                         TextWrapping="NoWrap">
                         <interactivity:Interaction.Behaviors>
                             <interactions:OverflowTextToolTipBehavior />

Screenbox/Pages/ArtistDetailsPage.xaml.cs

@@ -1,4 +1,6 @@
-using CommunityToolkit.Mvvm.DependencyInjection;
+#nullable enable
+
+using CommunityToolkit.Mvvm.DependencyInjection;
 using CommunityToolkit.WinUI;
 using CommunityToolkit.WinUI.Animations.Expressions;
 using Screenbox.Core;