Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: improve command bar style and resources #533

Merged
merged 4 commits into from
Jan 27, 2025
Merged

style: improve command bar style and resources #533

merged 4 commits into from
Jan 27, 2025

Conversation

United600
Copy link
Collaborator

@United600 United600 commented Jan 6, 2025 •
edited
Loading

  • Optimizes and improves the custom AppBarButton styles
  • Adds a CommandBar extension that enables some customization of the MoreButton
  • Adds a custom style and animation for the MoreButton
  • Reverses the selection CommandBar translation animation so it enters from the top and exits through the bottom
  • Changes the PlayQueue select all shortcut to function as a toggle, switching between selecting all and deselecting all items
  • Adds access keys to the media Details CommandBar
  • Improves the gamepad navigation of the media Details and FolderView pages

@United600
improve media details command bar
92a62a1 
add command bar extension

add ellipsis button style

add more button animation

invert selection command bar translation animation

improve gamepad navigation
@United600
improve play queue select all shortcut
6e91661
huynhsontung
huynhsontung reviewed Jan 25, 2025
View reviewed changes
Copy link
Owner

@huynhsontung huynhsontung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions about the CommandBarExtensions. Do we need to add more keyboard accelerators for the more button? What's the use case for feature?

Screenbox/App.xaml Outdated Show resolved Hide resolved
Screenbox/Controls/Extensions/CommandBarExtensions.cs Outdated Show resolved Hide resolved
@United600
Copy link
Collaborator Author

Just some questions about the CommandBarExtensions. Do we need to add more keyboard accelerators for the more button? What's the use case for feature?

Not really. It's more of a leftover.

@huynhsontung
Copy link
Owner

Please remove the unused method to avoid confusion. The keyboard accelerator setter is not technically accurate anyway.

@United600
remove unused method from extension
5a7c309 
remove implicitanimation from property
@huynhsontung huynhsontung merged commit a127e0d into huynhsontung:main Jan 27, 2025
4 checks passed
@United600 United600 deleted the command-bar branch January 27, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huynhsontung huynhsontung huynhsontung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@United600 @huynhsontung