Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: minor settings page improvements #537

Merged
merged 4 commits into from
Jan 27, 2025
Merged

chore: minor settings page improvements #537

merged 4 commits into from
Jan 27, 2025
+137 −102

Conversation

United600
Copy link
Collaborator

  • Removes the SettingsCard merged resource dictionary
  • Adds the RTL header icon for EnqueueAllFilesInFolder SettingsCard
  • Simplifies the SettingsExpander XY focus behavior, eliminating the need for a control to be set as a target

huynhsontung
huynhsontung approved these changes Jan 25, 2025
View reviewed changes
Copy link
Owner

@huynhsontung huynhsontung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This is very clean! Thank you for this.

@United600
Copy link
Collaborator Author

There are some control names I left that are now unnecessary

@huynhsontung huynhsontung merged commit f19f2bf into huynhsontung:main Jan 27, 2025
4 checks passed
@United600 United600 deleted the settings branch January 27, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huynhsontung huynhsontung huynhsontung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@United600 @huynhsontung