-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use uuid5 associated with file SHA1 instead of randomly generated uuid4 #11
Conversation
Using the uuid5 directly will rewrite the old entry in database with the new entry directly, if two images have a same SHA1. Maybe we should query the database to make sure the image doesn't exist in the db before copying and inserting? |
Due to considering the statefulness of the content in the payload, direct overwriting is not a good option, and the best way to do this is to perform appropriate checks to ensure that any data is not accidentally overwritten |
@hv0905 I think this PR is now ready to be merged into master (:з」∠) |
No description provided.