Improve OCR preprocess procedure. Improve performance. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pk5ls20
requested changes
Jan 4, 2024
There was a problem hiding this comment.
I think the preprocessing in the base OCRService class should remain the same as before (scaling + RGB conversion), and then the RGB-only preprocessing should be overridden in the EasyPaddleOCR class.
(because the scaling preprocessing is necessary if the user doesn't use EasyPaddleOCR, e.g. with easyocr)
…essing to include only RGB conversion.
pk5ls20
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.