Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the lifespan part #40

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Refactor the lifespan part #40

merged 3 commits into from
Jul 3, 2024

Conversation

pk5ls20
Copy link
Collaborator

@pk5ls20 pk5ls20 commented Jul 3, 2024

No description provided.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 3, 2024
@pk5ls20 pk5ls20 requested a review from hv0905 July 3, 2024 00:45
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.50%. Comparing base (fc7d148) to head (76ef675).

Files Patch % Lines
app/Services/storage/__init__.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   83.08%   83.50%   +0.41%     
==========================================
  Files          29       31       +2     
  Lines        1271     1291      +20     
==========================================
+ Hits         1056     1078      +22     
+ Misses        215      213       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pk5ls20 pk5ls20 enabled auto-merge July 3, 2024 00:49
@pk5ls20 pk5ls20 force-pushed the refactor/lifespan branch from fa9b1c2 to e8430cc Compare July 3, 2024 01:14
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jul 3, 2024
Copy link

codeclimate bot commented Jul 3, 2024

Code Climate has analyzed commit 76ef675 and detected 0 issues on this pull request.

View more on Code Climate.

@pk5ls20 pk5ls20 merged commit d01e75e into master Jul 3, 2024
8 checks passed
@hv0905 hv0905 deleted the refactor/lifespan branch July 3, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants