Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor local utilities and CLI interface #41

Merged
merged 5 commits into from
Jul 5, 2024
Merged

Conversation

hv0905
Copy link
Owner

@hv0905 hv0905 commented Jul 5, 2024

  • Rebuild local indexing to align its behaviour with upload API.
  • Rewrite CLI interface using Typer to have a more clear logic and provide more features.

@hv0905 hv0905 requested a review from pk5ls20 July 5, 2024 04:30
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Jul 5, 2024
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 91.22807% with 5 lines in your changes missing coverage. Please review.

Project coverage is 83.83%. Comparing base (d01e75e) to head (ae00f0f).

Files Patch % Lines
app/Services/storage/local_storage.py 71.42% 2 Missing ⚠️
app/Services/index_service.py 50.00% 1 Missing ⚠️
app/Services/storage/s3_compatible_storage.py 50.00% 1 Missing ⚠️
app/Services/upload_service.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   83.50%   83.83%   +0.33%     
==========================================
  Files          31       34       +3     
  Lines        1291     1324      +33     
==========================================
+ Hits         1078     1110      +32     
- Misses        213      214       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hv0905 hv0905 enabled auto-merge July 5, 2024 16:42
@hv0905 hv0905 merged commit d870b2d into master Jul 5, 2024
8 checks passed
Copy link

codeclimate bot commented Jul 5, 2024

Code Climate has analyzed commit ae00f0f and detected 0 issues on this pull request.

View more on Code Climate.

@hv0905 hv0905 deleted the refactor/local-util branch July 17, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants