Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in save dialog #105

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix bug in save dialog #105

wants to merge 3 commits into from

Conversation

eaglestone
Copy link
Contributor

Save dialogue changed to default to home directory and ensures .rb extension added

defaults to home directory and ensures .rb extension added by default
@rafmagana
Copy link
Contributor

Thanks for your PR, but this is what I get with your code: http://d.pr/i/2IWX, in your local you see ".rb"? which OS are you using? I changed your code to be:

fileName = Qt::FileDialog.getSaveFileName(self, tr("Save Ruby Code"), "#{Dir.home}/.rb")

and I get this: http://d.pr/i/tzN3, which is what your trying to accomplish, I think.

I'm on a Mac, with 10.8.2.

We appreciate.

@eaglestone
Copy link
Contributor Author

Hi and thanks for getting back.

I'm on Windows (7 and 8) and I get the opposit result to you on the mac.

My code gives: http://d.pr/i/Drw5 with the file type set to .rb

and yours gives: http://d.pr/i/S6ZD

I guess QT is implemented differently on each platform?

I'm trying to get KidsRuby to automatically add the .rb extension during
save it's a common problem for the kids at my school who often forget.

This is my first ever PR / contribution to an open source project so a big
thank you for being gentle with me! :o)

On 1 August 2013 19:15, Rafael Magana [email protected] wrote:

Thanks for your PR, but this is what I get with your code:
http://d.pr/i/2IWX, in your local you see ".rb"? which OS are you using?
I changed your code to be:

fileName = Qt::FileDialog.getSaveFileName(self, tr("Save Ruby Code"), "#{Dir.home}/.rb")

and I get this: http://d.pr/i/tzN3, which is what your trying to
accomplish, I think.

I'm on a Mac, with 10.8.2.

We appreciate.


Reply to this email directly or view it on GitHubhttps://github.com//pull/105#issuecomment-21958029
.

@deadprogram
Copy link
Member

@rafmagana did you retest this since @eaglestone made some additional commits?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants