chore: Rename HydroflowPlus to Hydro #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitkulshreshtha
requested review from
jhellerstein,
shadaj and
MingweiSamuel
Deploying hydroflow with
|
| Latest commit: |
808dce1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://19e46b97.hydroflow.pages.dev |
| Branch Preview URL: | https://rohit-hfp-rename.hydroflow.pages.dev |
jhellerstein
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Left you comments on merging with #1621 edits to README.md. Otherwise LGTM.
| @@ -24,7 +24,7 @@ Hydro provides a high-level language for the majority of developers called [Hydr | |||
|
|
|||
| ## Development Setup | |||
|
|
|||
| See the [quickstart section of the Hydroflow+ book](https://hydro.run/docs/hydroflow_plus/quickstart/) for instructions on installing Rust and getting started with the Hydroflow+ template. | |||
| See the [quickstart section of the Hydroflow+ book](https://hydro.run/docs/hydro/quickstart/) for instructions on installing Rust and getting started with the Hydroflow+ template. | |||
There was a problem hiding this comment.
Needs name change edits. I have a separate PR #1621 with suggested wording, but you'll still need to change the names of directories/files in the docs and links to those in the version in my PR.
There was a problem hiding this comment.
Yep. I will merge #1621 last.
Thanks for putting that CR together!
docs/docs/hydro/stageleft.mdx
Outdated
|
|
||
| import StageleftDocs from '../../../stageleft/README.md' | ||
|
|
||
| Under the hood, Hydroflow uses a library called Stageleft to power the `q!` macro and code generation logic. The following docs, from the Stageleft README, outline the core architecture of Stageleft. |
MingweiSamuel
approved these changes
Dec 20, 2024
|
Presumably something will break, but we will find out when we need to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.