fix: Support AGP8 namespace #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #467 +/- ##
=======================================
Coverage 47.24% 47.24%
=======================================
Files 3 3
Lines 472 472
=======================================
Hits 223 223
Misses 249 249 ☔ View full report in Codecov by Sentry. |
|
@hyochan I understand you are very busy,but could you check this PR? 🙏 |
|
Before merging the PR, I decide to use the following way. - flutter_inapp_purchase: ^5.6.0
+ flutter_inapp_purchase:
+ git:
+ url: https://github.com/dev-yakuza/flutter_inapp_purchase.git
+ ref: fix-agp8 |
hyochan
approved these changes
Dec 18, 2023
JoyHong
pushed a commit
to JoyHong/flutter_inapp_purchase
that referenced
this pull request
Jun 17, 2024
First, thanks for the great package. Now, Flutter supports `AGP8`, so I try to use it. But, I got the following error. ``` Namespace not specified. Specify a namespace in the module's build file. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace. If you've specified the package attribute in the source AndroidManifest.xml, you can use the AGP Upgrade Assistant to migrate to the namespace value in the build file. Refer to https://d.android.com/r/tools/upgrade-assistant/agp-upgrade-assistant for general information about using the AGP Upgrade Assistant. ain ``` And, I realize `flutter_inapp_purchase` doesn't support the `namespace`. This PR is not perfect to support the `AGP8`, but it can fix the `namespace` issue simply. Reference - flutter/flutter#125181 (comment) - flutter/flutter#125621 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, thanks for the great package.
Now, Flutter supports
AGP8, so I try to use it.But, I got the following error.
And, I realize
flutter_inapp_purchasedoesn't support thenamespace.This PR is not perfect to support the
AGP8, but it can fix thenamespaceissue simply.Reference
namespacein build.gradle due toNo signature of method: build_[...].android() is applicable for argument typeserror with AGP <4.2 flutter/flutter#125621 (comment)