Small typo + use sharedValue and elementValue instead of getting valu…

…e again
hypar-io · Jan 22, 2025 · 9dba881 · 9dba881
1 parent 69cbe69
commit 9dba881
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/Elements/src/Model.cs b/Elements/src/Model.cs
@@ -34,7 +34,7 @@ private class GatherSubElementsResult
             /// List of elements collected from the shared object's properties.
             ///
             /// If shared object is marked as JsonIgnore (e.g. RepresentationInstance), it will not be
-            /// serialized to JSON, but it's properties will be collected here so they can be used
+            /// serialized to JSON, but its properties will be collected here so they can be used
             /// during gltf serialization.
             /// </summary>
             public List<Element> ElementsFromSharedObjectProperties { get; } = new List<Element>();

diff --git a/Elements/src/Serialization/JSON/JsonInheritanceConverter.cs b/Elements/src/Serialization/JSON/JsonInheritanceConverter.cs
@@ -254,8 +254,8 @@ private void RemovePropertiesSameAsInSharedObject(Element element, JObject jObje
                     // compare each value in the dictionary
                     else if (Attribute.IsDefined(sharedProperty, typeof(JsonExtensionDataAttribute)))
                     {
-                        if (sharedProperty.GetValue(element.SharedObject) is IDictionary<string, object> extraDataFromSharedObject
-                            && property.GetValue(element) is IDictionary<string, object> extraDataFromElement)
+                        if (sharedValue is IDictionary<string, object> extraDataFromSharedObject
+                            && elementValue is IDictionary<string, object> extraDataFromElement)
                         {
                             foreach (var extraDataFromSharedObjectKey in extraDataFromSharedObject.Keys)
                             {