Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polygon: delete last vertex if it equals the first one #1026

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

katehryhorenko
Copy link
Contributor

@katehryhorenko katehryhorenko commented Sep 13, 2023

BACKGROUND:
In drywall function the data exported from Revit and then proceed by transformation/union etc. can cause the creation of polygon where the last vertex duplicated the first one. "Edges" method tries to create a segment from this two points and fails (the line is too short)

DESCRIPTION:

  • Delete the last vertex if it equals the first one as part of polygon validation

TESTING:

  • I published Drywall function with this change. It might be worth creating a test

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

This change is Reviewable

Copy link
Member

@andrewheumann andrewheumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is supposed to already be handled by the RemoveSequentialDuplicates method — can we investigate why that's not working? It is being called with wrap = true, which should mean it checks if the first / last vertex are identical. Perhaps something is being changed in the DeleteVerticesForOverlappingEdges method?

Reviewable status: 0 of 1 approvals obtained

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants