Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt DispatchWorkItem for scheduling tasks #16

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

minuscorp
Copy link
Contributor

@minuscorp minuscorp commented Dec 22, 2019

Adopt DispatchWorkItem for better Foundation, Dispatch and NIO interoperability.

Breaking changes:

  • reducerGroup does not depend on RxSwift anymore, so for managing subscriptions we use a Combine-like approach, where the Cancelables are just added to a [Cancelable] that can be cleaned up removeAll() or just released on deinit

@minuscorp minuscorp self-assigned this Dec 22, 2019
@minuscorp minuscorp added the enhancement New feature or request label Dec 22, 2019
@sebastianvarela
Copy link
Contributor

sebastianvarela commented Dec 22, 2019

SwiftLint found issues

Warnings

File Line Reason
DispatcherTests.swift 47 Types should be nested at most 1 level deep (nesting)
ObservableTypeTests.swift 15 Variable name should be between 3 and 40 characters long: 'by' (identifier_name)
ObservableTypeTests.swift 34 Method 'setUp()' should call to super function (overridden_super_call)
ObservableTypeTests.swift 47 Collection literals should not have trailing commas. (trailing_comma)
ObservableTypeTests.swift 58 Collection literals should not have trailing commas. (trailing_comma)

Errors

File Line Reason
ReducerTests.swift 20 Variable name should only contain alphanumeric characters: '_counter' (identifier_name)
ReducerTests.swift 52 Variable name should only contain alphanumeric characters: '_counter' (identifier_name)
ReducerTests.swift 76 Variable name should only contain alphanumeric characters: '_counter' (identifier_name)
ReducerTests.swift 106 Variable name should only contain alphanumeric characters: '_counter' (identifier_name)
ReducerTests.swift 133 Variable name should only contain alphanumeric characters: '_counter' (identifier_name)

Generated by 🚫 Danger

@sebastianvarela
Copy link
Contributor

@minuscorp Please, this PR is outdated and i want to unsubscribe from them. You can close this? :D

@minuscorp
Copy link
Contributor Author

Why is this outdated, also, if notifications bother you, you can choose to unwatch for changes on it. This approach was tested and valid, but none reviewed it before I left.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants