Feat refactor advanced network capture

.changeset/thick-snails-explain.md

@@ -0,0 +1,5 @@
+---
+'@hyperdx/node-opentelemetry': patch
+---
+
+Add the networkHeadersCapture and networkBodyCapture flags. Users can decide whether to capture the headers or body information through these two flags.

examples/hello-node-express/index.js

@@ -3,6 +3,8 @@ const { context, metrics, propagation, trace } = require('@opentelemetry/api');
 
 initSDK({
   // advancedNetworkCapture: true,
+  networkBodyCapture: false,
+  networkHeadersCapture: false,
   // betaMode: true,
   // consoleCapture: true,
 });

packages/node-opentelemetry/README.md

@@ -192,10 +192,11 @@ export HDX_NODE_BETA_MODE=1
 
 By enabling advanced network capture, the SDK will additionally capture full HTTP request/response headers
 and bodies for all inbound/outbound HTTP requests, to help with more in-depth request debugging.
-This can be accomplished by setting `HDX_NODE_ADVANCED_NETWORK_CAPTURE` environment variable to 1.
+This can be accomplished by setting `HDX_NODE_NETWORK_HEADERS_CAPTURE` and `HDX_NODE_NETWORK_BODY_CAPTURE` environment variables to 1.
 
 ```sh
-export HDX_NODE_ADVANCED_NETWORK_CAPTURE=1
+export HDX_NODE_NETWORK_HEADERS_CAPTURE=1
+export HDX_NODE_NETWORK_BODY_CAPTURE=1
 ```
 
 By default, all request/response headers will be captured. You can specify a custom list of headers to capture

packages/node-opentelemetry/__tests__/packageJsonComp.test.ts

@@ -0,0 +1,51 @@
+import { comparePackageVersions } from '../utils/comparison';
+
+describe('comparePackageJsonVersions', () => {
+  test('equal versions return true for ==', () => {
+    expect(comparePackageVersions('1.0.0', '==', '1.0.0')).toBe(true);
+  });
+
+  test('different versions return false for ==', () => {
+    expect(comparePackageVersions('1.0.0', '==', '1.0.1')).toBe(false);
+  });
+
+  test('higher version returns true for >', () => {
+    expect(comparePackageVersions('1.0.1', '>', '1.0.0')).toBe(true);
+  });
+
+  test('lower version returns false for >', () => {
+    expect(comparePackageVersions('1.0.0', '>', '1.0.1')).toBe(false);
+  });
+
+  test('higher version returns true for >= when versions are equal', () => {
+    expect(comparePackageVersions('1.0.0', '>=', '1.0.0')).toBe(true);
+  });
+
+  test('higher version returns true for >=', () => {
+    expect(comparePackageVersions('1.0.1', '>=', '1.0.0')).toBe(true);
+  });
+
+  test('lower version returns false for >=', () => {
+    expect(comparePackageVersions('1.0.0', '>=', '1.0.1')).toBe(false);
+  });
+
+  test('lower version returns true for <', () => {
+    expect(comparePackageVersions('1.0.0', '<', '1.0.1')).toBe(true);
+  });
+
+  test('higher version returns false for <', () => {
+    expect(comparePackageVersions('1.0.1', '<', '1.0.0')).toBe(false);
+  });
+
+  test('lower version returns true for <= when versions are equal', () => {
+    expect(comparePackageVersions('1.0.0', '<=', '1.0.0')).toBe(true);
+  });
+
+  test('lower version returns true for <=', () => {
+    expect(comparePackageVersions('1.0.0', '<=', '1.0.1')).toBe(true);
+  });
+
+  test('higher version returns false for <=', () => {
+    expect(comparePackageVersions('1.0.1', '<=', '1.0.0')).toBe(false);
+  });
+});