fix issue where new lines are not persisted to url params correctly #1229
+19
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandon-pereira
requested review from
a team and
SpencerTorres
and removed request for
a team
🦋 Changeset detectedLatest commit: cedcefa The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
E2E Test Results✅ All tests passed • 25 passed • 3 skipped • 204s
|
MikeShi42
reviewed
Sep 30, 2025
@MikeShi42 that makes sense! I've changed the implementation and fixed the other scenario! |
brandon-pereira
requested review from
pulpdrew
and removed request for
SpencerTorres
|
@pulpdrew if you have the capacity, mind reviewing this one? |
pulpdrew
previously approved these changes
Oct 6, 2025
There was a problem hiding this comment.
LGTM, with two notes:
- It seems like we're also not persisting newlines in the select or order by inputs. Have we thought about applying this parser to those as well?
- It looks like nuqs handles newlines by default in v2.2.3. v2.2 also makes some improvements that would be great to have for testing purposes, which we have so far been missing out on. That's a major version update though, so fine by me to not tackle that upgrade as a part of this issue!
|
pulpdrew
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I try to create a multi-line where statement in the UI, it does not persist the new line character, which leads to errors as well.
Fixes HDX-2527