Skip to content

Conversation

brandon-pereira
Copy link
Contributor

Adds support for ordering logs by clicking on the respective header.

  • Toggles between three states (unset, asc, desc).
  • Leverages the column aliases correctly so if aliases have special characters (ex DURATION as "Duration (ms)") they are correctly ordered as expected
  • Supports nested tables
  • Supports query params (on search page)
  • Adds tests for db row table and sorting logic

Demo:

Screen.Recording.2025-10-01.at.2.24.06.PM.mov

Fixes HDX-2317

Copy link

changeset-bot bot commented Oct 1, 2025

🦋 Changeset detected

Latest commit: febfa64

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview Comment Oct 3, 2025 10:42pm

@brandon-pereira brandon-pereira requested review from a team and SpencerTorres and removed request for a team October 1, 2025 20:30
Copy link
Contributor

github-actions bot commented Oct 1, 2025

E2E Test Results

All tests passed • 25 passed • 3 skipped • 193s

Status Count
✅ Passed 25
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 3

View full report →

@pulpdrew
Copy link
Contributor

pulpdrew commented Oct 1, 2025

One edge case to be aware of is that using JSON schema, this will break if the user doesn't specify a type for the property in the select query:

Screenshot 2025-10-01 at 4 47 32 PM

The error message is pretty reasonable so this might not be the biggest deal, but if it is possible to automatically solve or prevent the issue when they click the column header, that could be a nice improvement.

@brandon-pereira
Copy link
Contributor Author

brandon-pereira commented Oct 2, 2025

@pulpdrew I disabled sorting if its a JSON Dynamic type (for now) - I will make a ticket to improve this in the future.

@MikeShi42 I added support to the other tables!

</Text>
<DBTableChart
config={{
dateRange: searchedTimeRange,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the clickhouse inserts table, its currently broken in main

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks for the heads up! Assigned the issue to you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants